fix: allow physical region alter region options #5046

lyang24 · 2024-11-25T02:29:49Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#5042

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
allow set and unset of region options in alter physical region request.
How does this PR work? Need a brief introduction for the changed logic (optional)
allow Alter/ unset region options by passing the request to DataNode's mito engine.
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-11-25T02:29:55Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

waynexia

LGTM, thanks @lyang24

src/metric-engine/src/engine.rs

waynexia

Sorry, I forget one thing. The alter request must be processed by the underlying physical region (mito region) as well. Otherwise it's only presented in metasrv and causing inconsistency.

src/metric-engine/src/engine/alter.rs

codecov · 2024-11-25T03:00:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (91e9335) to head (e59ce45).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5046      +/-   ##
==========================================
- Coverage   84.00%   83.78%   -0.23%     
==========================================
  Files        1156     1156              
  Lines      216244   216327      +83     
==========================================
- Hits       181663   181251     -412     
- Misses      34581    35076     +495

WenyXu

LGTM, It would be perfect if you could add a test_alter_column_ttl_options test in the mito crate.

lyang24 · 2024-11-26T01:43:21Z

LGTM, It would be perfect if you could add a test_alter_column_ttl_options test in the mito crate.

Hi I added a test but I noticed the ttl did not persist after region restart. Can you help me understand with if its my test structure (region metadata not flushed?) or its a bug.

src/mito2/src/engine/alter_test.rs

killme2008 · 2024-11-27T02:29:11Z

@lyang24 Could you please rebase this branch with the main branch? There is a typo config issue.

killme2008 · 2024-11-27T03:54:21Z

@waynexia Please take a look.

lyang24 · 2024-11-27T04:19:01Z

@waynexia Please take a look.

thank you

waynexia

LGTM, this change won't affect metadata region.

github-actions bot added the docs-not-required This change does not impact docs. label Nov 25, 2024

lyang24 force-pushed the alter_region_opt_on_phy branch 3 times, most recently from 5385bcb to b9046f1 Compare November 25, 2024 02:41

lyang24 marked this pull request as ready for review November 25, 2024 02:41

lyang24 requested review from waynexia and a team as code owners November 25, 2024 02:41

waynexia approved these changes Nov 25, 2024

View reviewed changes

src/metric-engine/src/engine.rs Show resolved Hide resolved

zhongzc mentioned this pull request Nov 25, 2024

Release v0.10.1 #5047

Closed

2 tasks

waynexia requested changes Nov 25, 2024

View reviewed changes

WenyXu reviewed Nov 25, 2024

View reviewed changes

src/metric-engine/src/engine/alter.rs Outdated Show resolved Hide resolved

lyang24 force-pushed the alter_region_opt_on_phy branch 2 times, most recently from 46113d0 to a83071e Compare November 25, 2024 05:40

lyang24 requested review from WenyXu and waynexia November 25, 2024 06:21

WenyXu approved these changes Nov 25, 2024

View reviewed changes

lyang24 force-pushed the alter_region_opt_on_phy branch from a83071e to 5faf2f4 Compare November 26, 2024 01:41

lyang24 requested review from evenyag and v0y4g3r as code owners November 26, 2024 01:41

lyang24 commented Nov 26, 2024

View reviewed changes

src/mito2/src/engine/alter_test.rs Outdated Show resolved Hide resolved

lyang24 force-pushed the alter_region_opt_on_phy branch 2 times, most recently from 9d54adf to ecadb3a Compare November 26, 2024 07:32

allow physical region alter region options

e59ce45

lyang24 force-pushed the alter_region_opt_on_phy branch from b3f0b7e to e59ce45 Compare November 27, 2024 03:28

waynexia approved these changes Nov 27, 2024

View reviewed changes

waynexia added this pull request to the merge queue Nov 27, 2024

Merged via the queue into GreptimeTeam:main with commit 8bdef77 Nov 27, 2024
35 checks passed

killme2008 mentioned this pull request Nov 29, 2024

Alter request to physical region is forbidden #5042

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow physical region alter region options #5046

fix: allow physical region alter region options #5046

lyang24 commented Nov 25, 2024 •

edited

Loading

coderabbitai bot commented Nov 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

waynexia left a comment

waynexia left a comment

codecov bot commented Nov 25, 2024 •

edited

Loading

WenyXu left a comment

lyang24 commented Nov 26, 2024

killme2008 commented Nov 27, 2024

killme2008 commented Nov 27, 2024

lyang24 commented Nov 27, 2024

waynexia left a comment

fix: allow physical region alter region options #5046

fix: allow physical region alter region options #5046

Conversation

lyang24 commented Nov 25, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Nov 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

waynexia left a comment

Choose a reason for hiding this comment

waynexia left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

WenyXu left a comment

Choose a reason for hiding this comment

lyang24 commented Nov 26, 2024

killme2008 commented Nov 27, 2024

killme2008 commented Nov 27, 2024

lyang24 commented Nov 27, 2024

waynexia left a comment

Choose a reason for hiding this comment

lyang24 commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading